Skip to content

fix(search): use the correct dataset for snuba search #69013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

scefali
Copy link
Contributor

@scefali scefali commented Apr 16, 2024

Fixes SENTRY-37D9

@scefali scefali requested a review from a team as a code owner April 16, 2024 18:11
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.68%. Comparing base (4ed24e4) to head (573b874).
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69013       +/-   ##
===========================================
+ Coverage   65.17%   79.68%   +14.50%     
===========================================
  Files        6429     6427        -2     
  Lines      285164   285106       -58     
  Branches    49114    49103       -11     
===========================================
+ Hits       185861   227182    +41321     
+ Misses      96944    57559    -39385     
+ Partials     2359      365     -1994     
Files Coverage Δ
src/sentry/search/snuba/executors.py 96.37% <100.00%> (+<0.01%) ⬆️

... and 2334 files with indirect coverage changes

@scefali scefali merged commit 7083b34 into master Apr 18, 2024
49 checks passed
@scefali scefali deleted the fix/snuba-use-correct-dataset branch April 18, 2024 17:08
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants