Skip to content

fix(search): use the correct dataset for snuba search #69013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix(search): use the correct dataset for snuba search #69013

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3bc986
use the correct dataset for snuba search
Apr 16, 2024
cbabc49
Merge branch 'master' of github.com:getsentry/sentry into fix/snuba-u…
Apr 16, 2024
573b874
fix logic
Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions src/sentry/search/snuba/executors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ class InvalidQueryForExecutor(Exception):

class GroupAttributesPostgresSnubaQueryExecutor(PostgresSnubaQueryExecutor):
def get_basic_group_snuba_condition(
self, search_filter: SearchFilter, joined_entitity: Entity
self, search_filter: SearchFilter, joined_entity: Entity
) -> Condition:
"""
Returns the basic lookup for a search filter.
Expand All @@ -1131,22 +1131,22 @@ def get_basic_group_snuba_condition(
)

def get_basic_event_snuba_condition(
self, search_filter: SearchFilter, joined_entitity: Entity
self, search_filter: SearchFilter, joined_entity: Entity
) -> Condition:
"""
Returns the basic lookup for a search filter.
"""

dataset = Dataset.Events if joined_entitity.alias == "e" else Dataset.IssuePlatform
dataset = Dataset.Events if joined_entity.alias == "e" else Dataset.IssuePlatform

query_builder = UnresolvedQuery(
dataset=dataset,
entity=joined_entitity,
entity=joined_entity,
params={},
)
return query_builder.default_filter_converter(search_filter)

def get_assigned(self, search_filter: SearchFilter, joined_entitity: Entity) -> Condition:
def get_assigned(self, search_filter: SearchFilter, joined_entity: Entity) -> Condition:
"""
Returns the assigned lookup for a search filter.
"""
Expand Down Expand Up @@ -1182,7 +1182,7 @@ def get_assigned(self, search_filter: SearchFilter, joined_entitity: Entity) ->

return BooleanCondition(op=BooleanOp.OR, conditions=conditions)

def get_suggested(self, search_filter: SearchFilter, joined_entitity: Entity) -> Condition:
def get_suggested(self, search_filter: SearchFilter, joined_entity: Entity) -> Condition:
"""
Returns the suggested lookup for a search filter.
"""
Expand Down Expand Up @@ -1253,13 +1253,13 @@ def get_suggested(self, search_filter: SearchFilter, joined_entitity: Entity) ->
)

def get_assigned_or_suggested(
self, search_filter: SearchFilter, joined_entitity: Entity
self, search_filter: SearchFilter, joined_entity: Entity
) -> Condition:
return BooleanCondition(
op=BooleanOp.OR,
conditions=[
self.get_assigned(search_filter, joined_entitity),
self.get_suggested(search_filter, joined_entitity),
self.get_assigned(search_filter, joined_entity),
self.get_suggested(search_filter, joined_entity),
],
)

Expand Down Expand Up @@ -1430,8 +1430,9 @@ def query(
orderby=[OrderBy(sort_func, direction=Direction.DESC)],
limit=Limit(limit + 1),
)
dataset = Dataset.Events if joined_entity.alias == "e" else Dataset.IssuePlatform
request = Request(
dataset="events",
dataset=dataset,
app_id="group_attributes",
query=query,
tenant_ids=tenant_ids,
Expand All @@ -1447,7 +1448,7 @@ def query(
where=where_conditions,
)
request = Request(
dataset="events",
dataset=dataset,
app_id="group_attributes",
query=hits_query,
tenant_ids=tenant_ids,
Expand Down
Loading