feat(spans): Indexed spans for aggregate span waterfall #69016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wmak
approved these changes
Apr 24, 2024
shruthilayaj
deleted the
shruthi/feat/use-indexed-spans-for-agg-waterfall
branch
shruthilayaj
added
the
Trigger: Revert
|
PR reverted: 9401b10 |
getsentry-bot
added a commit
that referenced
this pull request
Apr 24, 2024
…)" This reverts commit 5e2cffe. Co-authored-by: shruthilayaj <63818634+shruthilayaj@users.noreply.github.com>
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
Switch to using indexed spans instead of nodestore after a certain cutoff date (it's when the bloom filter index on transaction name was added to spans dataset) I'm going to follow up with proper tests for indexed spans since these tests were written before we had a way to store them for tests
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
…)" This reverts commit 5e2cffe. Co-authored-by: shruthilayaj <63818634+shruthilayaj@users.noreply.github.com>
shruthilayaj
added a commit
that referenced
this pull request
May 1, 2024
Reopening #69016 basically updated slightly to use options to enable/disable indexed spans
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using indexed spans instead of nodestore after a certain cutoff date (it's when the bloom filter index on transaction name was added to spans dataset)
I'm going to follow up with proper tests for indexed spans since these tests were written before we had a way to store them for tests