fix(backup): Also filter UserOption by key #69027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the fix at #68943
github-actions
bot
added
the
Scope: Backend
hubertdeng123
approved these changes
Apr 16, 2024
azaslavsky
added a commit
that referenced
this pull request
Apr 22, 2024
The fixes in #68943 and #69027 worked, but now fail on comparison. This PR makes comparison clever enough to detect these "duplicate" UserOption entries and avoid them. This is a temporary fix. A more robust solution will prevent ever exporting such UserOptions, but that will take a while to percolate through the support window, so this should hold us over for the time being.
azaslavsky
added a commit
that referenced
this pull request
Apr 22, 2024
The fixes in #68943 and #69027 worked, but now fail on comparison. This PR makes comparison clever enough to detect these "duplicate" UserOption entries and avoid them. This is a temporary fix. A more robust solution will prevent ever exporting such UserOptions, but that will take a while to percolate through the support window, so this should hold us over for the time being.
azaslavsky
added a commit
that referenced
this pull request
Apr 22, 2024
The fixes in #68943 and #69027 worked, but now fail on comparison. This PR makes comparison clever enough to detect these "duplicate" UserOption entries and avoid them. This is a temporary fix. A more robust solution will prevent ever exporting such UserOptions, but that will take a while to percolate through the support window, so this should hold us over for the time being.
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
The fixes in #68943 and #69027 worked, but now fail on comparison. This PR makes comparison clever enough to detect these "duplicate" UserOption entries and avoid them. This is a temporary fix. A more robust solution will prevent ever exporting such UserOptions, but that will take a while to percolate through the support window, so this should hold us over for the time being.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the fix at #68943.