Skip to content

feat(ui): Add ActorBadge #69029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2024
Merged

feat(ui): Add ActorBadge #69029

merged 2 commits into from
Apr 16, 2024

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2024
@evanpurkhiser evanpurkhiser requested a review from a team April 16, 2024 19:32
ryan953
ryan953 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a paragraph to a story file that's like "look at idBadge/* for FOO And badges/* for BAR" so folks know the difference (and don't slap in new props to blur the difference)

@evanpurkhiser
Copy link
Member Author

Yeah. Though maybe we could even just rename these?

I would like to try and drop a bunch of usages of these where they're JUST used for avatars

@evanpurkhiser evanpurkhiser merged commit e5e9e93 into master Apr 16, 2024
39 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-ui-add-actorbadge branch April 16, 2024 20:02
@sentry-io Sentry.io
Copy link

sentry-io bot commented Apr 16, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'id') render(app/components/idBadge/index.stories) View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'id') render(app/components/idBadge/index.stories) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryan953 ryan953 ryan953 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evanpurkhiser @ryan953