-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(issue-platform): Allow assignee to be passed with the occurrence #69031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We want to allow issue platform customers to specify who should be assigned to the issues created from their occurrences. This assignee will only be used when creating a new issue, it won't change the assignee of an existing issue. Assignees can be team or user. We already have a format for passing this via the API, so I'm using this here too. The Actor format (separate from the `Actor` model which is being removed) allows us to specify the assignee in a structured way. The format is defined here: https://github.com/getsentry/sentry/blob/ef66c637e6a69de97552a1fd6b200e16939afa94/src/sentry/utils/actor.py#L41-L47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. is there a way to add a more e2e test that confirms behavior that the issue created by the issue platform then has a correct assignee?
ah i see your slack messsage, it is just passing in assignee, not doing anything with it. |
Yeah, I'll add a comprehensive test to |
Co-authored-by: Evan Purkhiser <evanpurkhiser@gmail.com>
We want to allow issue platform customers to specify who should be assigned to the issues created from their occurrences. This assignee will only be used when creating a new issue, it won't change the assignee of an existing issue.
Assignees can be team or user. We already have a format for passing this via the API, so I'm using this here too. The Actor format (separate from the
Actor
model which is being removed) allows us to specify the assignee in a structured way. The format is defined here:sentry/src/sentry/utils/actor.py
Lines 41 to 47 in ef66c63