Skip to content

chore(alerts): move weekly summary Monday -> Saturday #69032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

vartec
Copy link
Contributor

@vartec vartec commented Apr 16, 2024

Moving weekly summary schedule as agreed in ClickHouse capacity DACI action items.

I've validated that the report dates in title are generated dynamically, with end date being floor_to_utc_day(timezone.now()) and start date being end - 7 days.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vartec
Copy link
Contributor Author

vartec commented Apr 16, 2024

This is overridden in getsentry so you'll need to make the change there https://github.com/getsentry/getsentry/blob/04274a3d630398a6e70c378765acf0bc4d3d92f0/getsentry/conf/settings/defaults.py#L823-L826

Thank you!
I've added it there https://github.com/getsentry/getsentry/pull/13666

@vartec vartec requested a review from wedamija April 16, 2024 20:45
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's much value changing it here but you can merge it if you like

@vartec vartec merged commit 37047cb into master Apr 16, 2024
49 checks passed
@vartec vartec deleted the vartec/move-weekly-summary-monday-to-saturday branch April 16, 2024 20:47
@vartec
Copy link
Contributor Author

vartec commented Apr 16, 2024

Not sure if there's much value changing it here but you can merge it if you like

Consistency mainly — if someone looks it up here, like I did, they get the day we actually run these on.

@G-Rath
Copy link

G-Rath commented Apr 27, 2024

I'm on mobile so might have missed something, but:

  1. I came here after getting two of these on a Saturday, assuming it was a bug
  2. I liked getting these on Mondays
  3. https://docs.sentry.io/product/alerts/notifications/ still says weekly alerts will be sent on a Monday.

I'm not really expecting that this will get reverted or made customizable any time, but it could have been nice to get at least a heads up about the change 😅

@stepech
Copy link

stepech commented May 11, 2024

I have to agree with @G-Rath here, is there any way for us to customize this? I came here also looking for some issue and ready to report it as bug.

@ArnaudBarre
Copy link

Coming here for the same issue. I think I can deal with first day of the chart being Saturday, but receiving emails on Saturday is a no go and I will probably disable the feature if it's not customizable, which is sad because this is great to have a weekly summary of the volume of issues.

@stepech
Copy link

stepech commented May 14, 2024

We've managed to customize it by rewriting "saturday" to "monday" in /usr/local/lib/python3.11/site-packages/sentry/conf/server.py file as part of the enhance-image.sh script.

@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants