-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(alerts): move weekly summary Monday -> Saturday #69032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is overridden in getsentry so you'll need to make the change there https://github.com/getsentry/getsentry/blob/04274a3d630398a6e70c378765acf0bc4d3d92f0/getsentry/conf/settings/defaults.py#L823-L826
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's much value changing it here but you can merge it if you like
Consistency mainly — if someone looks it up here, like I did, they get the day we actually run these on. |
I'm on mobile so might have missed something, but:
I'm not really expecting that this will get reverted or made customizable any time, but it could have been nice to get at least a heads up about the change 😅 |
I have to agree with @G-Rath here, is there any way for us to customize this? I came here also looking for some issue and ready to report it as bug. |
Coming here for the same issue. I think I can deal with first day of the chart being Saturday, but receiving emails on Saturday is a no go and I will probably disable the feature if it's not customizable, which is sad because this is great to have a weekly summary of the volume of issues. |
We've managed to customize it by rewriting "saturday" to "monday" in |
Moving weekly summary schedule as agreed in ClickHouse capacity DACI action items.
I've validated that the report dates in title are generated dynamically, with end date being
floor_to_utc_day(timezone.now())
and start date being end - 7 days.