ref(crons): Set null for owner_user_id when a user is deleted #69034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Apr 16, 2024
| @@ -251,7 +251,7 @@ class Monitor(Model): | |||
| Type of monitor. Currently there are only CRON_JOB monitors. | |||
| """ | |||
|
|
|||
| owner_user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="CASCADE") | |||
| owner_user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="SET_NULL") | |||
There was a problem hiding this comment.
Nit: I think maybe it's better to use HybridCloudForeignKeyCascadeBehavior.SET_NULL. Both are valid, but it's easier to see all the options for other people looking for examples
There was a problem hiding this comment.
Yeah but we don't do it anywhere else lol
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-crons-set-null-for-owner-user-id-when-a-user-is-deleted
branch
from
87c90fa to
283b24b
Compare
|
This PR has a migration; here is the generated SQL for --
-- Alter field owner_user_id on monitor
--
-- (no-op) |
wedamija
approved these changes
Apr 16, 2024
markstory
approved these changes
Apr 16, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-set-null-for-owner-user-id-when-a-user-is-deleted
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.