From 283b24b742d9fb93f382ad5a0c43cc9bd45bd0ce Mon Sep 17 00:00:00 2001 From: Evan Purkhiser Date: Tue, 16 Apr 2024 16:19:22 -0400 Subject: [PATCH 1/2] ref(crons): Set null for owner_user_id when a user is deleted --- migrations_lockfile.txt | 2 +- ...9_update_monitor_owner_team_id_cascsade.py | 36 +++++++++++++++++++ src/sentry/monitors/models.py | 2 +- 3 files changed, 38 insertions(+), 2 deletions(-) create mode 100644 src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py diff --git a/migrations_lockfile.txt b/migrations_lockfile.txt index 03d87a66e4f3a1..55a4c562a69f16 100644 --- a/migrations_lockfile.txt +++ b/migrations_lockfile.txt @@ -9,5 +9,5 @@ feedback: 0004_index_together hybridcloud: 0016_add_control_cacheversion nodestore: 0002_nodestore_no_dictfield replays: 0004_index_together -sentry: 0698_remove_file_id_from_control_avatars +sentry: 0699_update_monitor_owner_team_id_cascsade social_auth: 0002_default_auto_field diff --git a/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py b/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py new file mode 100644 index 00000000000000..e9695d7a5a21af --- /dev/null +++ b/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py @@ -0,0 +1,36 @@ +# Generated by Django 5.0.3 on 2024-04-16 20:35 + +import sentry.db.models.fields.hybrid_cloud_foreign_key +from django.db import migrations + +from sentry.new_migrations.migrations import CheckedMigration + + +class Migration(CheckedMigration): + # This flag is used to mark that a migration shouldn't be automatically run in production. + # This should only be used for operations where it's safe to run the migration after your + # code has deployed. So this should not be used for most operations that alter the schema + # of a table. + # Here are some things that make sense to mark as post deployment: + # - Large data migrations. Typically we want these to be run manually so that they can be + # monitored and not block the deploy for a long period of time while they run. + # - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to + # run this outside deployments so that we don't block them. Note that while adding an index + # is a schema change, it's completely safe to run the operation after the code has deployed. + # Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment + + is_post_deployment = False + + dependencies = [ + ("sentry", "0698_remove_file_id_from_control_avatars"), + ] + + operations = [ + migrations.AlterField( + model_name="monitor", + name="owner_user_id", + field=sentry.db.models.fields.hybrid_cloud_foreign_key.HybridCloudForeignKey( + "sentry.User", db_index=True, null=True, on_delete="SET_NULL" + ), + ), + ] diff --git a/src/sentry/monitors/models.py b/src/sentry/monitors/models.py index 46bbece7dfbfb3..413666dd66edf5 100644 --- a/src/sentry/monitors/models.py +++ b/src/sentry/monitors/models.py @@ -251,7 +251,7 @@ class Monitor(Model): Type of monitor. Currently there are only CRON_JOB monitors. """ - owner_user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="CASCADE") + owner_user_id = HybridCloudForeignKey(settings.AUTH_USER_MODEL, null=True, on_delete="SET_NULL") """ The user assigned as the owner of this model. """ From 9db0f92ad9f417c4329c8810b22c8b1fa36f9bc9 Mon Sep 17 00:00:00 2001 From: "getsantry[bot]" <66042841+getsantry[bot]@users.noreply.github.com> Date: Tue, 16 Apr 2024 20:36:57 +0000 Subject: [PATCH 2/2] :hammer_and_wrench: apply pre-commit fixes --- .../migrations/0699_update_monitor_owner_team_id_cascsade.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py b/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py index e9695d7a5a21af..1ebfe02114ab4c 100644 --- a/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py +++ b/src/sentry/migrations/0699_update_monitor_owner_team_id_cascsade.py @@ -1,8 +1,8 @@ # Generated by Django 5.0.3 on 2024-04-16 20:35 -import sentry.db.models.fields.hybrid_cloud_foreign_key from django.db import migrations +import sentry.db.models.fields.hybrid_cloud_foreign_key from sentry.new_migrations.migrations import CheckedMigration