Skip to content

chore(trace-explorer): Make sample rate optional for trace explorer #69052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Zylphrex
Copy link
Member

This is likely the cause of there only being 1 span per trace. Let's make it optional so we can test turning it off and see how that affects results.

This is likely the cause of there only being 1 span per trace. Let's make it
optional so we can test turning it off and see how that affects results.
@Zylphrex Zylphrex requested a review from k-fish April 16, 2024 21:50
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.67%. Comparing base (604a22e) to head (05d0a94).
Report is 45 commits behind head on master.

❗ Current head 05d0a94 differs from pull request most recent head 3a216ef. Consider uploading reports for the commit 3a216ef to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69052       +/-   ##
===========================================
+ Coverage   54.00%   79.67%   +25.67%     
===========================================
  Files        5433     6427      +994     
  Lines      228412   285073    +56661     
  Branches    39284    49096     +9812     
===========================================
+ Hits       123360   227140   +103780     
+ Misses     104687    57567    -47120     
- Partials      365      366        +1     
Files Coverage Δ
src/sentry/api/endpoints/organization_traces.py 60.71% <100.00%> (ø)
src/sentry/options/defaults.py 100.00% <ø> (ø)

... and 2228 files with indirect coverage changes

@Zylphrex Zylphrex merged commit 6695d58 into master Apr 16, 2024
48 checks passed
@Zylphrex Zylphrex deleted the txiao/chore/make-sample-rate-optional-for-trace-explorer branch April 16, 2024 23:48
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants