Skip to content

chore(snuba): Pass referrer to get_groups_user_counts #69056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

ceorourke
Copy link
Member

The group model's method count_users_seen is called by a few different features but get_groups_user_counts hard codes the referrer so we can't tell who is actually calling it. This PR passes the referrer in with a description of where it's coming from.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
@ceorourke ceorourke changed the title ref(snuba): Pass referrer to get_groups_user_counts chore(snuba): Pass referrer to get_groups_user_counts Apr 16, 2024
@ceorourke ceorourke marked this pull request as ready for review April 16, 2024 22:53
@ceorourke ceorourke requested review from a team as code owners April 16, 2024 22:53
@ceorourke ceorourke requested a review from a team April 16, 2024 22:54
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need to update the snuba referrer enum?

Copy link
Contributor

@nhsiehgit nhsiehgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any tests

@ceorourke
Copy link
Member Author

do you need to update the snuba referrer enum?

Oh yeah I forget about that thing, do you know what the deal is with it? There's a ton of stuff defined in it but most of the variables aren't actually used anywhere.

@ceorourke
Copy link
Member Author

any tests

There are tests for each of these features, do you mean tests that check the referrer string?

@JoshFerge
Copy link
Member

do you need to update the snuba referrer enum?

Oh yeah I forget about that thing, do you know what the deal is with it? There's a ton of stuff defined in it but most of the variables aren't actually used anywhere.

i'm not sure about it being unused, but i know that there are checks somewhere where it compares the referrer string to those enums. can ask sns for further details if needed.

@ceorourke ceorourke merged commit 80f9de5 into master Apr 17, 2024
48 checks passed
@ceorourke ceorourke deleted the ceorourke/user-count-referrer branch April 17, 2024 16:46
Copy link

sentry-io bot commented Apr 17, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RateLimitExceeded: Query on could not be run due to allocation policies, details: {'ConcurrentRateLimitAllocationPol... sentry.tasks.post_process.post_process_group View Issue
  • ‼️ RateLimitExceeded: Query on could not be run due to allocation policies, details: {'ConcurrentRateLimitAllocationPol... sentry.tasks.post_process.post_process_group View Issue
  • ‼️ RateLimitExceeded: Query on could not be run due to allocation policies, details: {'ConcurrentRateLimitAllocationPol... sentry.tasks.digests.deliver_digest View Issue
  • ‼️ RateLimitExceeded: Query on could not be run due to allocation policies, details: {'ConcurrentRateLimitAllocationPol... sentry.tasks.digests.deliver_digest View Issue
  • ‼️ SnubaError: HTTPConnectionPool(host='127.0.0.1', port=10006): Max retries exceeded with url: /events/snql (Ca... sentry.tasks.post_process.post_process_group View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants