-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore(snuba): Pass referrer to get_groups_user_counts #69056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need to update the snuba referrer enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any tests
Oh yeah I forget about that thing, do you know what the deal is with it? There's a ton of stuff defined in it but most of the variables aren't actually used anywhere. |
There are tests for each of these features, do you mean tests that check the referrer string? |
i'm not sure about it being unused, but i know that there are checks somewhere where it compares the referrer string to those enums. can ask sns for further details if needed. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
The group model's method
count_users_seen
is called by a few different features butget_groups_user_counts
hard codes the referrer so we can't tell who is actually calling it. This PR passes the referrer in with a description of where it's coming from.