Skip to content

chore(hybridcloud) Shift logging around for gitlab #69059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

markstory
Copy link
Member

The most recent log volumes are not matching up with recorded hooks. I'd like to be able to correlate each webhook being saved with the identifier logging added earlier.

The most recent log volumes are not matching up with recorded hooks. I'd
like to be able to correlate each webhook being saved with the
identifier logging added earlier.
@markstory markstory requested a review from a team April 16, 2024 22:06
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
@@ -81,13 +81,20 @@ def get_response_from_gitlab_webhook(self):

try:
data = json.loads(self.request.body)
except ValueError as e:
logger.info("gitlab.body.parse_error", extra={"error": str(e)})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hasn't happened yet so it isn't a contributing factor to the incorrect mailbox sharding.

@markstory markstory merged commit 9dd0300 into master Apr 17, 2024
@markstory markstory deleted the gitlab-logging-hook branch April 17, 2024 14:35
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants