fix(replay): guard against experimental frames in breadcrumbs #69060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 18 bytes ⬆️
|
c298lee
approved these changes
Apr 16, 2024
michellewzhang
added a commit
that referenced
this pull request
Apr 17, 2024
better fix instead of #69060 show an error boundary around the breadcrumb rows if the breadcrumb frame is invalid for some reason, rather than breaking the entire tab. <img width="482" alt="SCR-20240417-jlyi" src="https://github.com/getsentry/sentry/assets/56095982/f51669ab-3253-4993-bca8-47a21e467f82"> fixes [JAVASCRIPT-2SJF](https://sentry.io/organizations/sentry/issues/?project=11276&query=JAVASCRIPT-2SJF) fixes [JAVASCRIPT-2SJG](https://sentry.io/organizations/sentry/issues/?project=11276&query=JAVASCRIPT-2SJG)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes JAVASCRIPT-2SJF
fixes JAVASCRIPT-2SJG
for mobile replays, we're experimenting with adding breadcrumbs, which means some of the frames we're sending in aren't complete (eg. they don't have all the properties that replay ones do).
this was leading to a problem rendering the breadcrumbs tab since we had a click frame that didn't have property
message, and we were trying to accessframe.message.we can probably delete this check after video replay breadcrumb frames are more complete/correct, but for now let's have this guard, so we don't get this error while the SDK engineers are testing breadcrumbs!
before:
after: