fix(trace-explorer): Query trace meta across all projects #69062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meta data needs to be queried across all projects or it will be incomplete as spans from other projects will augment the result.
github-actions
bot
added
the
Scope: Backend
JoshFerge
reviewed
Apr 17, 2024
| organization, | ||
| project_ids={-1}, | ||
| project_slugs=None, | ||
| include_all_accessible=True, |
There was a problem hiding this comment.
you technically don't need to set this to true since pasisng in -1 will set it
sentry/src/sentry/api/bases/organization.py
Line 370 in 824d4a8
JoshFerge
approved these changes
Apr 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meta data needs to be queried across all projects or it will be incomplete as spans from other projects will augment the result.