Skip to content

fix(issue-platform): Check permissions for assignees sent to the issue platform #69065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

wedamija
Copy link
Member

We should make sure that the assignee for an occurrence actually belongs to the org.

…e platform

We should make sure that the assignee for an occurrence actually belongs to the org.
@wedamija wedamija requested a review from a team April 16, 2024 22:37
@wedamija wedamija requested a review from a team as a code owner April 16, 2024 22:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.68%. Comparing base (2869247) to head (d1d0ce6).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69065       +/-   ##
===========================================
+ Coverage   58.20%   79.68%   +21.47%     
===========================================
  Files        6420     6429        +9     
  Lines      284855   285240      +385     
  Branches    49078    49130       +52     
===========================================
+ Hits       165809   227285    +61476     
+ Misses     118650    57564    -61086     
+ Partials      396      391        -5     
Files Coverage Δ
src/sentry/api/fields/actor.py 94.11% <100.00%> (+22.68%) ⬆️
src/sentry/issues/occurrence_consumer.py 93.93% <100.00%> (+29.88%) ⬆️
src/sentry/utils/actor.py 98.30% <100.00%> (+33.72%) ⬆️

... and 1905 files with indirect coverage changes

only fetch project if necessary
@wedamija wedamija merged commit 3ff4f2a into master Apr 17, 2024
49 checks passed
@wedamija wedamija deleted the danf/issue-platform-assignee-perms branch April 17, 2024 16:25
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants