ref(rules): Update typing in rule files #69068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
nhsiehgit
approved these changes
Apr 16, 2024
| @@ -236,8 +245,9 @@ def apply_rule(self, rule: Rule, status: GroupRuleStatus) -> None: | |||
| if not predicate_func(predicate_iter): | |||
| return | |||
| else: | |||
| self.logger.error( | |||
| f"Unsupported {name}_match {match!r} for rule {rule.id}", | |||
| log_string = f"Unsupported {name}_match {match!r} for rule {rule.id}" | |||
There was a problem hiding this comment.
does this need to be in a separate var?
There was a problem hiding this comment.
I got some error if i didn't: LOG011 avoid pre-formatting log messages
saponifi3d
approved these changes
Apr 16, 2024
| @@ -319,7 +346,7 @@ class EventFrequencyCondition(BaseEventFrequencyCondition): | |||
| label = "The issue is seen more than {value} times in {interval}" | |||
|
|
|||
| def query_hook( | |||
| self, event: GroupEvent, start: datetime, end: datetime, environment_id: str | |||
| self, event: GroupEvent, start: datetime, end: datetime, environment_id: int | |||
There was a problem hiding this comment.
ooo is it the ID and not the text now?
There was a problem hiding this comment.
I think this was just wrong before
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #69068 +/- ##
===========================================
+ Coverage 58.20% 79.64% +21.43%
===========================================
Files 6420 6429 +9
Lines 284855 285226 +371
Branches 49078 49128 +50
===========================================
+ Hits 165809 227161 +61352
+ Misses 118650 57674 -60976
+ Partials 396 391 -5
|
JoshFerge
reviewed
Apr 17, 2024
This was referenced Apr 30, 2024
schew2381
added a commit
that referenced
this pull request
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls out the non-functional changes from #68517 which are mostly typing related.