Skip to content

feat(group-attributes): Add migration to backfill group attributes #69071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 1, 2024

Conversation

snigdhas
Copy link
Member

This migration was run before as 0641_backfill_group_attributes. At that time, the self-hosted consumer wasn't ready so the backfill was a noop. Recommitting this migration so it can be run again for self-hosted customers. We won't need to run this for SaaS/ST.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0700_backfill_group_priority_to_self_hosted.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.68%. Comparing base (b8a12ef) to head (e4f7623).
Report is 1 commits behind head on master.

❗ Current head e4f7623 differs from pull request most recent head 8d74ff6. Consider uploading reports for the commit 8d74ff6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69071       +/-   ##
===========================================
+ Coverage   42.36%   79.68%   +37.32%     
===========================================
  Files        6477     6429       -48     
  Lines      288062   285231     -2831     
  Branches    49628    49129      -499     
===========================================
+ Hits       122032   227283   +105251     
+ Misses     163577    57557   -106020     
+ Partials     2453      391     -2062     

see 4621 files with indirect coverage changes

@snigdhas snigdhas marked this pull request as ready for review April 18, 2024 17:39
@snigdhas snigdhas requested a review from a team as a code owner April 18, 2024 17:39
@snigdhas snigdhas requested a review from a team April 18, 2024 17:40
Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this for ST customers, just not saas. So we should run this using the migration tool, and just kill the US and DE runs

Copy link
Contributor

@scefali scefali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR. Just to be clear, we need to land this change first so the attribute consumer is enabled: https://github.com/getsentry/sentry/pull/68633/files#diff-c4bf5bc2eae9efe5e948b5deda98c34fafd95674ae376aaf790c21a039e59f91L1897

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's also null out the old migration if we haven't already, no need to run it twice in self hosted

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0704_backfill_group_attributes_to_self_hosted.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/migrations/0709_backfill_group_attributes_to_self_hosted.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

Copy link
Contributor

github-actions bot commented May 1, 2024

This PR has a migration; here is the generated SQL for src/sentry/migrations/0711_backfill_group_attributes_to_self_hosted.py ()

--
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL

@snigdhas snigdhas force-pushed the snigdha/backfill-group-attributes-for-selfhosted branch from 4db0463 to 76943a3 Compare May 1, 2024 18:17
@snigdhas snigdhas merged commit ca736c3 into master May 1, 2024
47 checks passed
@snigdhas snigdhas deleted the snigdha/backfill-group-attributes-for-selfhosted branch May 1, 2024 18:48
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants