-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(group-attributes): Add migration to backfill group attributes #69071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(group-attributes): Add migration to backfill group attributes #69071
Conversation
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69071 +/- ##
===========================================
+ Coverage 42.36% 79.68% +37.32%
===========================================
Files 6477 6429 -48
Lines 288062 285231 -2831
Branches 49628 49129 -499
===========================================
+ Hits 122032 227283 +105251
+ Misses 163577 57557 -106020
+ Partials 2453 391 -2062 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this for ST customers, just not saas. So we should run this using the migration tool, and just kill the US and DE runs
src/sentry/migrations/0700_backfill_group_priority_to_self_hosted.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR. Just to be clear, we need to land this change first so the attribute consumer is enabled: https://github.com/getsentry/sentry/pull/68633/files#diff-c4bf5bc2eae9efe5e948b5deda98c34fafd95674ae376aaf790c21a039e59f91L1897
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, let's also null out the old migration if we haven't already, no need to run it twice in self hosted
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
This PR has a migration; here is the generated SQL for --
-- Raw Python operation
--
-- THIS OPERATION CANNOT BE WRITTEN AS SQL |
4db0463
to
76943a3
Compare
This migration was run before as
0641_backfill_group_attributes
. At that time, the self-hosted consumer wasn't ready so the backfill was a noop. Recommitting this migration so it can be run again for self-hosted customers. We won't need to run this for SaaS/ST.