Skip to content

feat(crons): Disallow teams not part of project to be selected for notifications #69073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

davidenwang
Copy link
Contributor

@davidenwang davidenwang commented Apr 16, 2024

Adds a new memberOfProjectSlug prop to the sentryMemberTeamSelectorField to restrict selectable teams to only be the ones that are associated with the provided project slug

image

related to: #63814

@davidenwang davidenwang requested a review from a team as a code owner April 16, 2024 23:26
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2024
Copy link

codecov bot commented Apr 17, 2024

Bundle Report

Changes will increase total bundle size by 4.4kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.2MB 4.4kB ⬆️

@davidenwang davidenwang merged commit 324537d into master Apr 18, 2024
41 checks passed
@davidenwang davidenwang deleted the davidenwang/disallow-non-project-team branch April 18, 2024 20:30
Copy link

sentry-io bot commented Apr 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'some') iteratee(app/components/forms/fields/sentryMemb... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants