-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(issue-platform): Use assignee passed to the issue platform to assign to group #69076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -237,6 +238,15 @@ def save_issue_from_occurrence( | |||
"sdk": normalized_sdk_tag_from_event(event), | |||
}, | |||
) | |||
if is_new and occurrence.assignee: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth quickly making an option to deploy this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of putting the option on the crons side so we can stop sending them. This code is pretty well enclosed in try/catch so I'm not too worried about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although maybe it'd be wise to enclose assign
in a try/catch too...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #69076 +/- ##
=========================================
Coverage ? 79.61%
=========================================
Files ? 6429
Lines ? 285257
Branches ? 49132
=========================================
Hits ? 227111
Misses ? 57755
Partials ? 391
|
…sign to group This hooks up the new assignee that we pass to the issue platform to actually perform the assignment
a69665d
to
8525d65
Compare
This hooks up the new assignee that we pass to the issue platform to actually perform the assignment