Skip to content

feat(issue-platform): Use assignee passed to the issue platform to assign to group #69076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

wedamija
Copy link
Member

This hooks up the new assignee that we pass to the issue platform to actually perform the assignment

@wedamija wedamija requested a review from a team April 16, 2024 23:42
@wedamija wedamija requested a review from a team as a code owner April 16, 2024 23:42
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 16, 2024
@@ -237,6 +238,15 @@ def save_issue_from_occurrence(
"sdk": normalized_sdk_tag_from_event(event),
},
)
if is_new and occurrence.assignee:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth quickly making an option to deploy this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of putting the option on the crons side so we can stop sending them. This code is pretty well enclosed in try/catch so I'm not too worried about it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although maybe it'd be wise to enclose assign in a try/catch too...

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@3ff4f2a). Click here to learn what that means.

❗ Current head a69665d differs from pull request most recent head 8525d65. Consider uploading reports for the commit 8525d65 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #69076   +/-   ##
=========================================
  Coverage          ?   79.61%           
=========================================
  Files             ?     6429           
  Lines             ?   285257           
  Branches          ?    49132           
=========================================
  Hits              ?   227111           
  Misses            ?    57755           
  Partials          ?      391           
Files Coverage Δ
src/sentry/api/fields/actor.py 94.11% <100.00%> (ø)
src/sentry/issues/occurrence_consumer.py 93.93% <100.00%> (ø)
src/sentry/utils/actor.py 98.30% <100.00%> (ø)
src/sentry/issues/ingest.py 96.09% <71.42%> (ø)

Base automatically changed from danf/issue-platform-assignee-perms to master April 17, 2024 16:25
…sign to group

This hooks up the new assignee that we pass to the issue platform to actually perform the assignment
@wedamija wedamija force-pushed the danf/issue-platform-apply-assignee-to-group branch from a69665d to 8525d65 Compare April 17, 2024 16:26
@wedamija wedamija merged commit 5c1fea9 into master Apr 17, 2024
47 of 48 checks passed
@wedamija wedamija deleted the danf/issue-platform-apply-assignee-to-group branch April 17, 2024 17:10
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants