Skip to content

ref(replays): add error boundaries around breadcrumb rows #69110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Apr 17, 2024

better fix instead of #69060

show an error boundary around the breadcrumb rows if the breadcrumb frame is invalid for some reason, rather than breaking the entire tab.

SCR-20240417-jlyi

fixes JAVASCRIPT-2SJF
fixes JAVASCRIPT-2SJG

@michellewzhang michellewzhang requested a review from a team as a code owner April 17, 2024 17:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Bundle Report

Changes will decrease total bundle size by 43.21kB ⬇️

Bundle name Size Change
app-webpack-bundle-array-push 26.26MB 43.21kB ⬇️

@michellewzhang michellewzhang merged commit 0cffcff into master Apr 17, 2024
@michellewzhang michellewzhang deleted the mz/error-bound-breadcrumbs branch April 17, 2024 17:59
@github-actions github-actions bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants