feat(integrations): allow to rotate client secret of Internal/Public integrations, frontend part #69115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 1.7kB ⬆️
|
ykamo001
reviewed
Apr 18, 2024
Comment on lines
+329
to
+340
| <Fragment> | ||
| <Header>{t('Rotated Client Secret')}</Header> | ||
| <Body> | ||
| <Alert type="info" showIcon> | ||
| {t('This will be the only time your client secret is visible!')} | ||
| </Alert> | ||
| <p> | ||
| {t('Your client secret is:')} | ||
| <code>{rotateResponse.clientSecret}</code> | ||
| </p> | ||
| </Body> | ||
| </Fragment> |
There was a problem hiding this comment.
I think i created a component such that the value is only shown once, would that fit your needs? You wouldn't have to worry about wording and everything because you could just pass in the token
ykamo001
approved these changes
Apr 18, 2024
oioki
added a commit
that referenced
this pull request
Apr 22, 2024
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
…integrations, frontend part (#69115) To be merged after #69015 <img width="1167" alt="image" src="https://github.com/getsentry/sentry/assets/1127549/eb8ba4bf-2596-4ce5-be74-8386d1bacbc1">
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged after #69015