feat(sentry-apps): hide clientSecret in 1 day after creation #69289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69289 +/- ##
===========================================
+ Coverage 62.76% 79.71% +16.95%
===========================================
Files 6461 6431 -30
Lines 286611 286015 -596
Branches 49414 49300 -114
===========================================
+ Hits 179891 228007 +48116
+ Misses 106292 57571 -48721
- Partials 428 437 +9
|
ykamo001
approved these changes
Apr 22, 2024
| @@ -91,13 +94,14 @@ def serialize(self, obj, attrs, user, access): | |||
| is_active_superuser(env.request) or is_active_staff(env.request) | |||
| ) | |||
| if elevated_user or owner.id in user_org_ids: | |||
| has_secret = obj.date_added > timezone.now() - timedelta(days=1) | |||
There was a problem hiding this comment.
nit: I think show_secret might be a better name for this, because that's what this is helping determine and holding the value of right?
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #69015 #69115