Skip to content

ref(replays): refactor query code #69334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Apr 19, 2024

  • make use of date_filter_optional=False for filter params
  • rename query_replays_collection_raw to query_replays_collection_paginated, and remove query_replays_collection (this is no longer needed for compatibility with getsentry, since we moved the delete replays script to sentry)
  • use .get() instead of .pop() in post_process.generate_normalized_output and group/alphabetize the fields
  • misc small typing, naming, and docstring improvements

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 19, 2024
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 95.89041% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.68%. Comparing base (3644f5c) to head (621aa57).
Report is 984 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #69334      +/-   ##
==========================================
+ Coverage   78.66%   79.68%   +1.02%     
==========================================
  Files        6622     6446     -176     
  Lines      294737   286426    -8311     
  Branches    49377    49350      -27     
==========================================
- Hits       231855   228241    -3614     
+ Misses      62460    57748    -4712     
- Partials      422      437      +15     
Files Coverage Δ
...y/replays/endpoints/organization_replay_details.py 97.56% <ø> (+2.21%) ⬆️
...try/replays/endpoints/organization_replay_index.py 98.46% <100.00%> (ø)
src/sentry/replays/query.py 86.77% <100.00%> (+0.59%) ⬆️
src/sentry/replays/scripts/delete_replays.py 100.00% <100.00%> (+57.50%) ⬆️
src/sentry/replays/usecases/query/__init__.py 96.96% <100.00%> (ø)
src/sentry/replays/validators.py 100.00% <ø> (ø)
src/sentry/replays/post_process.py 97.79% <98.33%> (-0.05%) ⬇️
...ntry/replays/endpoints/project_replay_viewed_by.py 90.14% <60.00%> (-2.40%) ⬇️

... and 497 files with indirect coverage changes

@aliu39 aliu39 changed the title Aliu/ref replay queries ref(replays): refactor query code Apr 20, 2024
@aliu39 aliu39 marked this pull request as ready for review April 20, 2024 01:00
@aliu39 aliu39 requested a review from a team as a code owner April 20, 2024 01:00
@getsantry getsantry bot added the Stale label May 11, 2024
@getsantry
Copy link
Contributor

getsantry bot commented May 11, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@aliu39
Copy link
Member Author

aliu39 commented May 13, 2024

Closing as this is outdated and a lot of changes to review - might come back to later

@aliu39 aliu39 closed this May 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
@aliu39 aliu39 deleted the aliu/ref-replay-queries branch June 17, 2024 23:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant