Skip to content

feat(sidebar): disable tooltip when floating accordion is open #69346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 11, 2024

Conversation

DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Apr 19, 2024

Some have felt it feels a bit annoying when the tooltip overlaps the floating sidebar, this PR is up to see how people feel about the attempt to fix this, we don't have to merge this in necessarily.

In this PR i'm disabling the tooltip for the floating accordion item only. So when you click on an item with subitems, the tooltip will immediately disappear for the current item and can only reappear when you close the sub menu. This also means that all tooltips still work when nothing is open.

There are two other alternatives, let me know if there are any strong feelings towards them

  1. Completely disable tooltips for all items which have sub items (I personally like have some tooltips, so I like the current solution)
  2. Hide the tooltip onclick, and still allow the tooltip if you hover back onto the item (I think I like this option the most, but it sounds a little more tricky)

Before behaviour immediately after clicking the item
image

After behaviour immediately after clicking the item
image

@DominikB2014 DominikB2014 requested review from cleptric and a team April 19, 2024 20:10
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 19, 2024
@cleptric
Copy link
Member

@vuluongj20 can we merge this?

@DominikB2014 DominikB2014 merged commit 751ef4a into master May 11, 2024
45 checks passed
@DominikB2014 DominikB2014 deleted the DominikB2014/dont-show-tooltip-nested-accordion branch May 11, 2024 19:32
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants