Revert "Revert "feat(code-mappings): Add support for stacktrace frames with backslashes for automatic code mappings #70164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
May 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR un-reverts (re-reverts 🤔) this PR, which adds automatic code mapping support for events with backslashes in the file path. This PR was reverted out of an abundance of caution when the
derive_code_mappingstask was killing memcache in s4s during the response to #inc-716. This occurred because:derive_code_mappingspings the cache twice per event to ensure that we only process one event per project per hour, and with no duplicate issues per 24 hours.After having a conversation with @beezz, we determined that this would be highly unlikely to occur in SaaS (and there would be much bigger problems in that scenario), even given the higher traffic we'd expect to see in this task as a result of allowing more kinds of events to be supported for automatic code mappings.