-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
perf: move assemble status to redis #70344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70344 +/- ##
===========================================
+ Coverage 50.59% 79.90% +29.31%
===========================================
Files 6473 6503 +30
Lines 288640 289975 +1335
Branches 49726 49950 +224
===========================================
+ Hits 146029 231714 +85685
+ Misses 142199 57848 -84351
- Partials 412 413 +1
|
9ef47a1
to
888a35d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic to read/write values looks good to me once the type issues are sorted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
PR reverted: c486707 |
This reverts commit 2163d6a. Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
Dual writes to memcache and redis while transitioning assemble status to redis
Ref: #68598