Skip to content

perf: move assemble status to redis #70344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented May 6, 2024

Dual writes to memcache and redis while transitioning assemble status to redis

Ref: #68598

@anonrig anonrig requested review from mitsuhiko, markstory, asottile-sentry and a team May 6, 2024 15:23
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 6, 2024
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (5cee6c2) to head (888a35d).
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #70344       +/-   ##
===========================================
+ Coverage   50.59%   79.90%   +29.31%     
===========================================
  Files        6473     6503       +30     
  Lines      288640   289975     +1335     
  Branches    49726    49950      +224     
===========================================
+ Hits       146029   231714    +85685     
+ Misses     142199    57848    -84351     
- Partials      412      413        +1     
Files Coverage Δ
src/sentry/conf/server.py 89.23% <100.00%> (-0.02%) ⬇️
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
src/sentry/tasks/assemble.py 89.45% <100.00%> (+61.53%) ⬆️
src/sentry/testutils/helpers/redis.py 100.00% <100.00%> (+46.15%) ⬆️

... and 2102 files with indirect coverage changes

Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic to read/write values looks good to me once the type issues are sorted.

Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig anonrig merged commit 2163d6a into master May 6, 2024
49 checks passed
@anonrig anonrig deleted the anonrig/move-assemble-status branch May 6, 2024 17:08
Copy link

sentry-io bot commented May 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 'Invalid cluster type, expected redis cluster' /api/0/organizations/{organization_slug}/releas... View Issue

Did you find this useful? React with a 👍 or 👎

@anonrig anonrig added the Trigger: Revert Add to a merged PR to revert it (skips CI) label May 6, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: c486707

getsentry-bot added a commit that referenced this pull request May 6, 2024
This reverts commit 2163d6a.

Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants