Skip to content

perf: move assemble status to redis #70376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024
Merged

perf: move assemble status to redis #70376

merged 1 commit into from
May 6, 2024

Conversation

anonrig
Copy link
Contributor

@anonrig anonrig commented May 6, 2024

Reverts the revert

Required to land after https://github.com/getsentry/getsentry/pull/13883

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 6, 2024
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anonrig anonrig marked this pull request as ready for review May 6, 2024 19:48
@anonrig anonrig requested a review from a team May 6, 2024 19:48
@anonrig anonrig enabled auto-merge (squash) May 6, 2024 19:49
@anonrig anonrig merged commit 7efeed8 into master May 6, 2024
50 checks passed
@anonrig anonrig deleted the revert-assemble-status branch May 6, 2024 20:02
Copy link

sentry-io bot commented May 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 'Invalid cluster type, expected redis cluster' sentry.tasks.assemble.assemble_artifacts View Issue

Did you find this useful? React with a 👍 or 👎

@anonrig anonrig added the Trigger: Revert Add to a merged PR to revert it (skips CI) label May 6, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 3486624

getsentry-bot added a commit that referenced this pull request May 6, 2024
This reverts commit 7efeed8.

Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
@anonrig
Copy link
Contributor Author

anonrig commented May 6, 2024

@markstory @asottile-sentry Any idea why this is failing once again?

@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants