ref: add metric when canonical key falls back #70385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70385 +/- ##
==========================================
- Coverage 79.97% 79.97% -0.01%
==========================================
Files 6495 6495
Lines 289790 289817 +27
Branches 49928 49933 +5
==========================================
+ Hits 231753 231773 +20
- Misses 57625 57632 +7
Partials 412 412
|
jan-auer
approved these changes
May 7, 2024
|
unfortunately it looks like this is still used according to the metrics so backing this out |
asottile-sentry
added
the
Trigger: Revert
|
PR reverted: 21a2f1c |
getsentry-bot
added a commit
that referenced
this pull request
May 7, 2024
This reverts commit 571c43c. Co-authored-by: asottile-sentry <103459774+asottile-sentry@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
want to make sure this isn't happening before I clean up all of this -- I'm told this is handled by relay now