Skip to content

ref(api-idorslug): endpoint changes for renaming organization_slug to organization_id_or_slug #70389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

iamrajjoshi
Copy link
Member

@iamrajjoshi iamrajjoshi commented May 6, 2024

This PR includes Notable Logic changes from #70384.

Rest of the changes from the pr are renaming.

Note: The diff seems incorrect for some of the tests at the end.

@iamrajjoshi iamrajjoshi added the Do Not Merge Don't merge label May 6, 2024
@iamrajjoshi iamrajjoshi self-assigned this May 6, 2024
@iamrajjoshi iamrajjoshi changed the title ref(api-idorslug): ednpoint changes for renaming organization_slug to organization_id_or_slug ref(api-idorslug): endpoint changes for renaming organization_slug to organization_id_or_slug May 6, 2024
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented May 6, 2024

Bundle Report

Changes will increase total bundle size by 20.17kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.54MB 20.17kB ⬆️

Copy link
Member

@sentaur-athena sentaur-athena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review all of this because it seems like there are some merge issues. Can you please take care of them and ping me back for review?

@iamrajjoshi iamrajjoshi force-pushed the raj/api-idorslug/rename-path-params/organization_slug_endpoints branch from 0219466 to 8cf43b7 Compare May 7, 2024 18:36
@iamrajjoshi iamrajjoshi force-pushed the raj/api-idorslug/rename-path-params/organization_slug_endpoints branch from 8cf43b7 to bce987a Compare May 7, 2024 18:48
@iamrajjoshi iamrajjoshi requested a review from sentaur-athena May 7, 2024 18:48
@sentaur-athena sentaur-athena removed the Scope: Frontend Automatically applied to PRs that change frontend components label May 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants