Skip to content

feat(api-idorslug): Updated Subset of Endpoints to use organization_id_or_slug #70636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamrajjoshi
Copy link
Member

A subset of changes from #70081!

@iamrajjoshi iamrajjoshi self-assigned this May 10, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.04%. Comparing base (07ac900) to head (f220635).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70636      +/-   ##
==========================================
+ Coverage   79.06%   80.04%   +0.97%     
==========================================
  Files        6502     6502              
  Lines      290526   290541      +15     
  Branches    50067    50069       +2     
==========================================
+ Hits       229699   232554    +2855     
+ Misses      60388    57549    -2839     
+ Partials      439      438       -1     
Files Coverage Δ
...ndpoints/codeowners/external_actor/user_details.py 100.00% <100.00%> (ø)
src/sentry/api/endpoints/group_details.py 89.30% <ø> (ø)
...ts/integrations/organization_integrations/index.py 100.00% <ø> (ø)
...ints/notifications/notification_actions_details.py 100.00% <ø> (ø)
...points/notifications/notification_actions_index.py 100.00% <ø> (ø)
.../endpoints/organization_code_mapping_codeowners.py 92.30% <100.00%> (ø)
...api/endpoints/organization_code_mapping_details.py 91.30% <100.00%> (ø)
...ry/api/endpoints/organization_dashboard_details.py 98.83% <100.00%> (+13.95%) ⬆️
.../sentry/api/endpoints/organization_member/index.py 99.40% <ø> (ø)
src/sentry/api/endpoints/organization_projects.py 94.17% <ø> (ø)
... and 15 more

... and 258 files with indirect coverage changes

@iamrajjoshi iamrajjoshi marked this pull request as ready for review May 10, 2024 03:40
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 10, 2024 03:40
@iamrajjoshi iamrajjoshi removed request for a team May 10, 2024 03:40
@iamrajjoshi iamrajjoshi merged commit 3aade54 into master May 10, 2024
47 of 49 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/api-idorslug/rename-path-params/organization_slug_6 branch May 10, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants