Skip to content

feat(api-idorslug): Update Subset of Monitor & Integration Endpoints and to use organization_id_or_slug #70784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

iamrajjoshi
Copy link
Member

A subset of changes from #70081!

@iamrajjoshi iamrajjoshi self-assigned this May 13, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 80.03%. Comparing base (48d9c5c) to head (6040ddc).

❗ Current head 6040ddc differs from pull request most recent head 6a7bef1. Consider uploading reports for the commit 6a7bef1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #70784       +/-   ##
===========================================
+ Coverage   51.69%   80.03%   +28.33%     
===========================================
  Files        6473     6504       +31     
  Lines      289458   290756     +1298     
  Branches    49918    50118      +200     
===========================================
+ Hits       149643   232694    +83051     
+ Misses     139374    57625    -81749     
+ Partials      441      437        -4     
Files Coverage Δ
...c/sentry/api/endpoints/organization_unsubscribe.py 94.25% <100.00%> (+48.27%) ⬆️
src/sentry/api/urls.py 100.00% <ø> (ø)
src/sentry/integrations/bitbucket/urls.py 100.00% <ø> (ø)
src/sentry/integrations/github/urls.py 100.00% <ø> (ø)
src/sentry/integrations/gitlab/urls.py 100.00% <ø> (ø)
src/sentry/integrations/jira/urls.py 100.00% <ø> (ø)
src/sentry/integrations/jira_server/urls.py 100.00% <ø> (ø)
src/sentry/integrations/vsts/urls.py 100.00% <ø> (ø)
...rs/endpoints/organization_monitor_checkin_index.py 100.00% <ø> (+4.76%) ⬆️
...monitors/endpoints/organization_monitor_details.py 100.00% <ø> (+10.71%) ⬆️
... and 7 more

... and 2109 files with indirect coverage changes

@iamrajjoshi iamrajjoshi marked this pull request as ready for review May 13, 2024 18:49
@iamrajjoshi iamrajjoshi requested review from a team as code owners May 13, 2024 18:49
@iamrajjoshi iamrajjoshi removed request for a team May 13, 2024 18:49
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update the comments here too to be accurate to what is happening (ie. all the references to slug)

Copy link
Member

@sentaur-athena sentaur-athena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please address the nits before merging.

@iamrajjoshi iamrajjoshi merged commit 64eae03 into master May 13, 2024
47 of 48 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/api-idorslug/rename-path-params/organization_slug_9 branch May 13, 2024 23:19
Copy link

sentry-io bot commented May 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ IntegrityError: UniqueViolation('duplicate key value violates unique constraint "auth_user_username_key"\nDETAIL:... pytest.runtest.protocol tests/sentry/middleware... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants