Skip to content

fix(hc): Change RPC schemas to be represented as OpenAPI vs #70876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2024

Conversation

markstory
Copy link
Member

Mulligan on #68345 that resolves the import issue that required a revert.

@markstory markstory requested review from a team as code owners May 14, 2024 18:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 80.00%. Comparing base (d896596) to head (320eca9).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70876      +/-   ##
==========================================
- Coverage   80.01%   80.00%   -0.01%     
==========================================
  Files        6505     6506       +1     
  Lines      290884   290920      +36     
  Branches    50138    50145       +7     
==========================================
+ Hits       232739   232753      +14     
- Misses      57711    57733      +22     
  Partials      434      434              
Files Coverage Δ
src/sentry/services/hybrid_cloud/sig.py 93.50% <50.00%> (+0.17%) ⬆️
src/sentry/services/hybrid_cloud/rpc.py 90.69% <64.28%> (-2.48%) ⬇️

... and 8 files with indirect coverage changes

@markstory markstory merged commit bad3cf7 into master May 14, 2024
50 of 52 checks passed
@markstory markstory deleted the rpc-compatibility-v2 branch May 14, 2024 19:33
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants