feat(nodestore) FilestoreNodeStorage, all credits to #76250 #82126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This was referenced Dec 15, 2024
rophy
force-pushed
the
rophy/issue-76250
branch
from
3984e7c to
b13f0db
Compare
|
Any chance you could add some tests for this? |
Sure, I'll try to put up something over a weeekend. |
|
Note that this, when used with s3-compatible object storage such as MinIO, will result in buckets with "lots of small files". I actually enabled this internally in my on-premise envs. Performance of the MinIO turned out to be horrible after certain volume. |
|
Added a few tests. Since the implementation does not actually rely on S3Filestore logics, the tests do not configure anything specific for S3, and is ran against default Filestore which I think is a wapper of Django File. |
rophy
force-pushed
the
rophy/issue-76250
branch
from
da93a79 to
168a90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #76250 (comment)
While the original PR says "S3 Node Store", all the S3 logics actually come from configured File Store.
So I think "FilestoreNodeStorage" is probably a better term to describe the brilliant idea from @klboke
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.