feat(bitbucket-server): CODEOWNERS support and stacktrace linking #86639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
added
the
Trigger: getsentry tests
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
0b412c3 to
6a322ee
Compare
github-actions
bot
removed
the
Trigger: getsentry tests
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
2 times, most recently
from
f0f7151 to
6d4f32c
Compare
cathteng
reviewed
Mar 10, 2025
| parsed_url = urlparse(url) | ||
| qs = parse_qs(parsed_url.query) | ||
|
|
||
| if "at" in qs and len(qs["at"]) == 1: |
There was a problem hiding this comment.
could you explain what the "at" means here? i am curious how this is different from bitbucket
There was a problem hiding this comment.
i see, at refers to the branch i think
Comment on lines
+358
to
+357
| if repo.url is None: | ||
| return "" | ||
| parsed_repo_url = urlparse(repo.url) | ||
| parsed_url = urlparse(url) | ||
| return parsed_url.path.replace(parsed_repo_url.path + "/", "") |
There was a problem hiding this comment.
i'm also curious how this is different from bitbucket, it kind of looks the same?
cathteng
approved these changes
Mar 11, 2025
cathteng
added
the
Trigger: getsentry tests
|
can you add any screenshots / videos to show this works? |
github-actions
bot
removed
the
Trigger: getsentry tests
|
@cathteng done! check out the PR description. |
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
3a06de3 to
357114f
Compare
iamrajjoshi
added
the
Trigger: getsentry tests
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
357114f to
4c383ac
Compare
github-actions
bot
removed
the
Trigger: getsentry tests
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
4c383ac to
4df64f5
Compare
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
4df64f5 to
3f9dc48
Compare
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>
Co-authored-by: Cathy Teng <70817427+cathteng@users.noreply.github.com>
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
3f9dc48 to
65d0804
Compare
jianyuan
force-pushed
the
feat/codeowners-bitbucket-server
branch
from
65d0804 to
c5069d2
Compare
|
revert failed (conflict? already reverted?) -- check the logs |
iamrajjoshi
added
Trigger: getsentry tests
auto-merge was automatically disabled
April 30, 2025 09:52
Head branch was pushed to by a user without write access
github-actions
bot
removed
the
Trigger: getsentry tests
iamrajjoshi
added
the
Trigger: getsentry tests
github-actions
bot
removed
the
Trigger: getsentry tests
iamrajjoshi
added
the
Trigger: getsentry tests
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitbucket Server CODEOWNERS and stacktrace linking support. Note that the API URLs for Bitbucket Server are slightly different that that for Bitbucket Cloud.
Screenshots