feat(azure-devops): CODEOWNERS support #86958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iamrajjoshi
added
the
Trigger: getsentry tests
iamrajjoshi
reviewed
Mar 12, 2025
| api_version=self.api_version, | ||
| method=method, | ||
| api_version_preview=self.api_version_preview if api_preview else "", | ||
| ) | ||
| kwargs.setdefault("headers", {}).update(new_headers) | ||
| kwargs["headers"] = {**base_headers, **(kwargs.get("headers", {}))} |
There was a problem hiding this comment.
curious why this change was required?
There was a problem hiding this comment.
prepare_headers() returns a dictionary with an Accept key. I need to override the header to Accept: */* in the following method. I thought allowing user-provided headers to take precedence would make sense.
iamrajjoshi
approved these changes
Mar 13, 2025
jianyuan
force-pushed
the
feat/codeowners-azure-devops
branch
from
03e7ca2 to
64d53a3
Compare
github-actions
bot
removed
the
Trigger: getsentry tests
sentaur-athena
added
the
Trigger: getsentry tests
|
@jianyuan sorry for delay in merging. Can you please resolve the conflict? |
jianyuan
force-pushed
the
feat/codeowners-azure-devops
branch
from
64d53a3 to
add487f
Compare
github-actions
bot
removed
the
Trigger: getsentry tests
jianyuan
force-pushed
the
feat/codeowners-azure-devops
branch
from
add487f to
82f13f8
Compare
iamrajjoshi
added
the
Trigger: getsentry tests
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CODEOWNERS support for Azure DevOps
Screenshots