deps(ui): Upgrade react aria April 2025 #87821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takes us from the September 30, 2024 Release to the March 5, 2025 Release. Some fixes for mergeProps and others might be the most interesting for us.
github-actions
bot
added
the
Scope: Frontend
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
# Conflicts: # package.json
scttcper
changed the title
|
This update will also fix: let me know if you need any help to get this over the finish line 🙏 |
TkDodo
reviewed
May 7, 2025
Comment on lines
-215
to
+210
| const focusedItem = state.collection.getItem(state.selectionManager.focusedKey)?.props | ||
| const focusedItem = state.collection.getItem(state.selectionManager.focusedKey!)?.props |
There was a problem hiding this comment.
in the other PR I opened, I had fixed this differently without a no-null assertion:
const focusedItem: string | undefined = state.selectionManager.focusedKey
? state.collection.getItem(state.selectionManager.focusedKey)?.props?.value
: undefined;
There was a problem hiding this comment.
this isn’t resolved yet, we’re still using the no-null assertion here even though this is fixable with a runtime check
# Conflicts: # static/app/components/searchQueryBuilder/tokens/filterKeyListBox/index.tsx
TkDodo
reviewed
Jun 2, 2025
static/app/components/searchQueryBuilder/tokens/filterKeyListBox/useFilterKeyListBox.tsx
Outdated
Show resolved
Hide resolved
…ox/useFilterKeyListBox.tsx Co-authored-by: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
|
Ah, we just merged these two little changes in: I think this means we need to update |
# Conflicts: # package.json
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 2, 2025
fixes DE-22 Takes us from the September 30, 2024 Release to the May 19, 2025 Release. Some fixes for mergeProps and others might be the most interesting for us. [changelog](https://react-spectrum.adobe.com/releases/index.html) --------- Co-authored-by: Malachi Willey <malwilley@gmail.com> Co-authored-by: Dominik Dorfmeister <dominik.dorfmeister@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes DE-22
Takes us from the September 30, 2024 Release to the May 19, 2025 Release. Some fixes for mergeProps and others might be the most interesting for us.
changelog