ref(insights): Refactor cache- + queues- page widgets
#89344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
changed the base branch from
master
to
ref-insights-combine-data-fetching-with-chart-rendering-cursor-results
github-actions
bot
added
the
Scope: Backend
billyvg
changed the base branch from
ref-insights-combine-data-fetching-with-chart-rendering-cursor-results
to
master
billyvg
changed the base branch from
master
to
ref-insights-combine-data-fetching-with-chart-rendering
billyvg
removed
the
Scope: Backend
billyvg
commented
Apr 10, 2025
| data: cacheMissRateData, | ||
| error: cacheMissRateError, | ||
| } = useSpanMetricsSeries( | ||
| const {error: cacheMissRateError} = useSpanMetricsSeries( |
There was a problem hiding this comment.
Dupe request because of error handling :'(
billyvg
changed the title
cacheLandingPage widgets
Base automatically changed from
ref-insights-combine-data-fetching-with-chart-rendering
to
master
April 11, 2025 17:05
billyvg
force-pushed
the
ref-insights-combine-widgets-cache
branch
from
644abfd to
12b9f54
Compare
billyvg
changed the base branch from
master
to
feat-insights-pass-props-to-insights-chart-widgets
Base automatically changed from
feat-insights-pass-props-to-insights-chart-widgets
to
master
April 15, 2025 13:01
billyvg
force-pushed
the
ref-insights-combine-widgets-cache
branch
from
69b937b to
f0dffb1
Compare
billyvg
changed the title
cacheLandingPage widgetscache- + queues- page widgets
billyvg
commented
Apr 15, 2025
Comment on lines
+8
to
+12
| const {destination} = useLocationQuery({ | ||
| fields: { | ||
| destination: decodeScalar, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
This does mean that if this chart were rendered via the drawer, it needs to be on the Queues Summary Page (or have destination in query params). It's an optional param but I wonder if we want to be more strict about it?
We have a similar situation with the resources charts, it uses groupId url parameter
There was a problem hiding this comment.
Maybe! I think this is okay for now, though.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89344 +/- ##
==========================================
- Coverage 87.67% 85.29% -2.39%
==========================================
Files 10217 10170 -47
Lines 576083 573435 -2648
Branches 22691 22577 -114
==========================================
- Hits 505104 489116 -15988
- Misses 70554 83769 +13215
- Partials 425 550 +125 |
billyvg
force-pushed
the
ref-insights-combine-widgets-cache
branch
from
ec72227 to
fa47fc2
Compare
gggritso
approved these changes
Apr 17, 2025
Comment on lines
+8
to
+12
| const {destination} = useLocationQuery({ | ||
| fields: { | ||
| destination: decodeScalar, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Maybe! I think this is okay for now, though.
billyvg
added a commit
that referenced
this pull request
Apr 24, 2025
This PR creates a "chart widget" similar to what we did for Insights widgets (e.g. #89344). This is so that we can deep-link to the `EventGraph` using only `groupId` from URL parameters. This also makes some changes to `EventGraph` so that we can use a custom date range (/page filters). This is used when we click a release bubble, we want the chart in the drawer to refetch the same stats (but at a different interval) according to the bubble's time bucket. Part of #88560
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #88560
Follow-up to #89325