ref(flags): remove statsPeriod in flag details query #89360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
aliu39
changed the title
aliu39
commented
Apr 10, 2025
| @@ -36,25 +36,20 @@ export function FlagDetailsDrawerContent() { | |||
|
|
|||
| const sortArrow = <IconArrow color="gray300" size="xs" direction="down" />; | |||
|
|
|||
| const flagQuery = useMemo(() => { | |||
There was a problem hiding this comment.
this is a very cheap computation so don't need the memo
aliu39
changed the title
michellewzhang
approved these changes
Apr 10, 2025
aliu39
changed the title
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
The backend uses statsPeriod to clamp date range - imo we don't need this since we're already paginating.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend uses statsPeriod to clamp date range - imo we don't need this since we're already paginating.