ref: abstract on_create_or_update_comment_error method #89683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
jianyuan
commented
Apr 15, 2025
| @@ -526,8 +527,8 @@ def test_comment_workflow_api_error(self, mock_metrics, mock_issues): | |||
|
|
|||
| with pytest.raises(ApiError): | |||
| github_comment_workflow(self.pr.id, self.project.id) | |||
| assert cache.get(self.cache_key) is None | |||
| mock_metrics.incr.assert_called_with("github.pr_comment.api_error") | |||
| assert cache.get(self.cache_key) is None | |||
There was a problem hiding this comment.
These were not previously run because the assertions occur after the exception is raised, which is then absorbed by the pytest.raises context manager.
cathteng
approved these changes
Apr 17, 2025
cathteng
added
the
Trigger: getsentry tests
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
on_create_or_update_comment_errorhandler generic. They are used in both PR and Open PR workflows. The ultimate goal is to make the PR and Open PR workflows generic.