feat(releases): Refactor to support deep-linked Issues Chart #89711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
billyvg
changed the base branch from
master
to
billy/replay-2-releases-drawer-needs-to-have-deeplinks
billyvg
changed the title
billyvg
force-pushed
the
billy/replay-39-refactor-the-chart-from-eventgraph
branch
from
8014f45 to
54d0c2d
Compare
billyvg
force-pushed
the
billy/replay-39-refactor-the-chart-from-eventgraph
branch
from
2992d1d to
a7026d8
Compare
billyvg
changed the base branch from
billy/replay-2-releases-drawer-needs-to-have-deeplinks
to
master
billyvg
commented
Apr 23, 2025
| label={t('Users')} | ||
| /> | ||
| </SummaryContainer> | ||
| {showSummary ? ( |
There was a problem hiding this comment.
Fixes a bug in Release drawer where this is shown during loading state.
michellewzhang
approved these changes
Apr 23, 2025
| /> | ||
| </SummaryContainer> | ||
| ) : ( | ||
| <div /> |
There was a problem hiding this comment.
could this be null or undefined instead?
There was a problem hiding this comment.
Container is a grid so it needs an empty el unfortunately :(
| @@ -26,7 +27,13 @@ interface Props extends LoadableChartWidgetProps { | |||
| export function ChartWidgetLoader(props: Props) { | |||
| const query = useQuery<{default: React.FC<LoadableChartWidgetProps>}>({ | |||
| queryKey: [`widget-${props.id}`], | |||
| queryFn: () => import(`sentry/views/insights/common/components/widgets/${props.id}`), | |||
| queryFn: () => { | |||
| if (props.id === EVENT_GRAPH_WIDGET_ID) { | |||
There was a problem hiding this comment.
does this lead to circular dependencies?
There was a problem hiding this comment.
Good thinking... it could if we used ChartWidgetLoader to always load EventGraph, but we shouldn't need to. It'll only be the Insights widgets that we replace with WidgetLoader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a "chart widget" similar to what we did for Insights widgets (e.g. #89344). This is so that we can deep-link to the
EventGraphusing onlygroupIdfrom URL parameters.This also makes some changes to
EventGraphso that we can use a custom date range (/page filters). This is used when we click a release bubble, we want the chart in the drawer to refetch the same stats (but at a different interval) according to the bubble's time bucket.Part of #88560