Skip to content

feat(demo-mode): analytics #89720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2025
Merged

Conversation

obostjancic
Copy link
Member

Closes TET-86: Investigate adding plausible to sandbox

Essentially reverts #89468 and moves that logic to django template

@obostjancic obostjancic requested a review from a team as a code owner April 16, 2025 07:43
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Apr 16, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #89720      +/-   ##
==========================================
+ Coverage   81.35%   87.77%   +6.41%     
==========================================
  Files       10206    10190      -16     
  Lines      575469   574735     -734     
  Branches    22653    22508     -145     
==========================================
+ Hits       468182   504468   +36286     
+ Misses     106853    69842   -37011     
+ Partials      434      425       -9     

@shellmayr
Copy link
Member

Looks good now - thanks for fixing the domain thing 🙏

@obostjancic obostjancic merged commit fcc4460 into master Apr 17, 2025
66 checks passed
@obostjancic obostjancic deleted the ogi/feat/demo-mode-template-analytics branch April 17, 2025 09:07
@obostjancic obostjancic added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Apr 17, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: b0eba88

getsentry-bot added a commit that referenced this pull request Apr 17, 2025
This reverts commit fcc4460.

Co-authored-by: obostjancic <86684834+obostjancic@users.noreply.github.com>
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
This reverts commit fcc4460.

Co-authored-by: obostjancic <86684834+obostjancic@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants