Skip to content

feat(codecov): Introduce Virtual Diff Renderer #89853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2025

Conversation

nicholas-codecov
Copy link
Contributor

This PR adds in a virtual diff renderer.

This render comes packed with a couple of features:

  • Tokenizes & highlights diff content
  • "Scroll to line" after a user has selected a line and navigates to that page again
  • Dynamically enabled scrollbar
  • Transparent textarea for native search
  • Coverage highlighting
Screenshot 2025-04-17 at 09 18 21

@nicholas-codecov nicholas-codecov requested a review from a team as a code owner April 17, 2025 13:38
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 17, 2025
@nsdeschenes nsdeschenes added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 22, 2025
@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 22, 2025
@nsdeschenes nsdeschenes added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 22, 2025
@nsdeschenes nsdeschenes merged commit 1b644e8 into master Apr 22, 2025
46 of 47 checks passed
@nsdeschenes nsdeschenes deleted the nd/feat-codecov-build-out-virtual-diff-renderer branch April 22, 2025 17:03
billyvg pushed a commit that referenced this pull request Apr 22, 2025
This PR adds in a virtual diff renderer. 

This render comes packed with a couple of features:

- Tokenizes & highlights diff content
- "Scroll to line" after a user has selected a line and navigates to
that page again
- Dynamically enabled scrollbar
- Transparent `textarea` for native search
- Coverage highlighting

<img width="1192" alt="Screenshot 2025-04-17 at 09 18 21"
src="https://github.com/user-attachments/assets/00428fe1-71aa-456c-aae9-2a02170b0e28"
/>
andrewshie-sentry pushed a commit that referenced this pull request Apr 22, 2025
This PR adds in a virtual diff renderer. 

This render comes packed with a couple of features:

- Tokenizes & highlights diff content
- "Scroll to line" after a user has selected a line and navigates to
that page again
- Dynamically enabled scrollbar
- Transparent `textarea` for native search
- Coverage highlighting

<img width="1192" alt="Screenshot 2025-04-17 at 09 18 21"
src="https://github.com/user-attachments/assets/00428fe1-71aa-456c-aae9-2a02170b0e28"
/>
@github-actions github-actions bot locked and limited conversation to collaborators May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants