ref(github): PR comment workflow #89969
Conversation
github-actions
bot
added
the
Scope: Backend
jianyuan
force-pushed
the
ref/github-pr-comment-workflow
branch
from
04a1f86 to
08c1d6d
Compare
| def format_comment_url(url: str, referrer: str) -> str: | ||
| return url + "?referrer=" + referrer | ||
|
|
||
| def get_comment_body(self, issue_ids: list[int]) -> str: |
There was a problem hiding this comment.
This was previously split into two methods which I've decided to combine so that it is easier to implement for each integration.
issue_comment_contents = get_comment_contents(top_5_issue_ids)
# ...
comment_body = format_comment(issue_comment_contents)
iamrajjoshi
added
the
Trigger: getsentry tests
| return raw_snql_query(request, referrer=self.referrer.value)["data"] | ||
|
|
||
|
|
||
| def run_pr_comment_workflow(integration_name: str, pr_id: int, project_id: int) -> None: |
There was a problem hiding this comment.
can we move the run_pr_comment_workflow function logic into the task itself? i don't think we need it to live as a separate function if it only is run in the task
There was a problem hiding this comment.
@cathteng did you mean src/sentry/integrations/github/tasks/pr_comment.py or somewhere else?
There was a problem hiding this comment.
yes please, since that task is only calling this function
There was a problem hiding this comment.
@cathteng Ah, my plan is to make it generic so that it can be used by other integrations as well (i.e., GitLab, Bitbucket, Azure).
There was a problem hiding this comment.
it should be generic because we are using functions from the installation which would be implemented by other providers, right?
github-actions
bot
removed
the
Trigger: getsentry tests
jianyuan
force-pushed
the
ref/github-pr-comment-workflow
branch
from
f1f4651 to
942dd2f
Compare
cathteng
added
the
Trigger: getsentry tests
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Make the PR comment workflow generic. Migrate the GitHub integration to utilize it.
This PR is built on top of #89683.