Skip to content

button: remove buttonlabel #89997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Apr 21, 2025

Remove the rest of the buttonlabels and the now redundant wrapper

@JonasBa JonasBa requested review from a team as code owners April 21, 2025 18:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 21, 2025
Copy link

codecov bot commented Apr 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10255 1 10254 5
View the top 1 failed test(s) by shortest run time
AutofixSolution treats empty repos array as having no repository constraints
Stack Traces | 0.055s run time
Error: expect(element).toBeEnabled()

Received element is not enabled:
  <button aria-describedby="«r2e»" aria-disabled="true" aria-label="Code It Up" class="css-1i205pb-StyledButton-getColors-getFocusState-getColors-getSizeStyles-getBoxShadow-getButtonStyles e140qn371" disabled="" role="button" type="button" />
    at Object.<anonymous> (.../events/autofix/autofixSolution.spec.tsx:189:28)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:121:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@JonasBa
Copy link
Member Author

JonasBa commented Apr 21, 2025

Can't merge this yet, there is a bug with text display that will require changing the internals of the button

@JonasBa JonasBa added the Do Not Merge Don't merge label Apr 21, 2025
@JonasBa JonasBa closed this Apr 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Don't merge Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants