ref(uptime): Simplify consumer with one-to-one proj_sub <-> sub #90202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-uptime-simplify-consumer-with-one-to-one-proj-sub-sub
branch
2 times, most recently
from
972d425 to
cb30a89
Compare
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-uptime-simplify-consumer-with-one-to-one-proj-sub-sub
branch
from
cb30a89 to
e587bb2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #90202 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 10248 10248
Lines 578596 578586 -10
Branches 22696 22696
=======================================
- Hits 507595 507592 -3
+ Misses 70558 70551 -7
Partials 443 443 |
This merges the handle_result_for_project into handler_result, since we can now assume there's a single ProjectUptimeSubscription for every UptimeSubscription, thus we don't need to fan out
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-uptime-simplify-consumer-with-one-to-one-proj-sub-sub
branch
from
e587bb2 to
4fc5906
Compare
wedamija
approved these changes
Apr 23, 2025
evanpurkhiser
deleted the
evanpurkhiser/ref-uptime-simplify-consumer-with-one-to-one-proj-sub-sub
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
evanpurkhiser
added
the
Trigger: Revert
|
PR reverted: f08b664 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the handle_result_for_project into handler_result, since we
can now assume there's a single ProjectUptimeSubscription for every
UptimeSubscription, thus we don't need to fan out