fix: set default environment to production only if environment is None

src/sentry/feedback/usecases/create_feedback.py

@@ -132,7 +132,9 @@ def fix_for_issue_platform(event_data: dict[str, Any]) -> dict[str, Any]:
     ret_event["platform"] = event_data.get("platform", "other")
     ret_event["level"] = event_data.get("level", "info")
 
-    ret_event["environment"] = event_data.get("environment", "production")
+    environment = event_data.get("environment")
+    ret_event["environment"] = environment or "production"
+
     release_value = event_data.get("release")
     if release_value:
         ret_event["release"] = release_value

tests/sentry/feedback/usecases/test_create_feedback.py

@@ -302,6 +302,21 @@ def test_corrected_still_works():
     assert isinstance(fixed_event["received"], str)
 
 
+@pytest.mark.parametrize("environment", ("missing", None, "", "my-environment"))
+def test_fix_for_issue_platform_environment(environment):
+    event = mock_feedback_event(1)
+    if environment == "missing":
+        event.pop("environment", "")
+    else:
+        event["environment"] = environment
+
+    fixed_event = fix_for_issue_platform(event)
+    if environment == "my-environment":
+        assert fixed_event["environment"] == environment
+    else:
+        assert fixed_event["environment"] == "production"
+
+
 @django_db_all
 def test_create_feedback_filters_unreal(default_project, mock_produce_occurrence_to_kafka):
     event = {