feat(aci): add monitor config form #90501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
43728e7 to
5df5e80
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
5df5e80 to
b0f0cfb
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
37be5b3 to
0eae557
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
fd61b71 to
c4909ce
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
c4909ce to
0df449f
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
810df1e to
edcdd4b
Compare
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
8c2aae8 to
0020453
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
0020453 to
2851b09
Compare
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
a6a1a91 to
ae5919e
Compare
natemoo-re
changed the title
This reverts commit 2851b09.
natemoo-re
force-pushed
the
aci/nm/monitor-settings
branch
from
79713bb to
8a5b4f4
Compare
scttcper
reviewed
May 16, 2025
Co-authored-by: Scott Cooper <scttcper@gmail.com>
scttcper
approved these changes
May 16, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 20, 2025
Adds the basic metric monitor config form to ACI. Also tackles a bit of general UI cleanup and adds more monitor-related hooks. Sorry for the large PR! @ameliahsu graciously split a few smaller branches off from this, so this is a bit of a catch-all PR. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com> Co-authored-by: Scott Cooper <scttcper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the basic metric monitor config form to ACI. Also tackles a bit of general UI cleanup and adds more monitor-related hooks.
Sorry for the large PR! @ameliahsu graciously split a few smaller branches off from this, so this is a bit of a catch-all PR.