Skip to content

chore(perf-issues): Setup N+1 DB query experiment #90530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Apr 28, 2025

Similar to #90070 but for the N+1 DB query detector.

This PR has no functional changes, and the new group type is not released, so will not produce any results.
A follow up PR will have the detector changes, and roll them out internally to test.

@leeandher leeandher requested a review from roggenkemper April 28, 2025 19:40
@leeandher leeandher requested review from a team as code owners April 28, 2025 19:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 28, 2025
Copy link

codecov bot commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 94.93088% with 11 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tectors/experiments/n_plus_one_db_span_detector.py 91.66% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #90530    +/-   ##
========================================
  Coverage   87.78%   87.78%            
========================================
  Files       10261    10263     +2     
  Lines      580109   580326   +217     
  Branches    22636    22636            
========================================
+ Hits       509240   509443   +203     
- Misses      70434    70448    +14     
  Partials      435      435            

@leeandher leeandher force-pushed the leander/setup-npo-db branch from 8dbfada to 8d463f3 Compare April 28, 2025 20:06
@leeandher leeandher merged commit d74d576 into master Apr 28, 2025
64 checks passed
@leeandher leeandher deleted the leander/setup-npo-db branch April 28, 2025 20:38
andrewshie-sentry pushed a commit that referenced this pull request May 12, 2025
Similar to #90070 but for the
N+1 DB query detector.

This PR has no functional changes, and the new group type is not
released, so will not produce any results.
A follow up PR will have the detector changes, and roll them out
internally to test.
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants