Skip to content

feat(replay): make user.geo fields searchable #91313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 16, 2025
Merged

feat(replay): make user.geo fields searchable #91313

merged 4 commits into from
May 16, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented May 8, 2025

@aliu39 aliu39 requested a review from a team as a code owner May 8, 2025 22:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 8, 2025
@codecov Codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:

Error parsing JUnit XML in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml at 1:159171

Caused by:
    RuntimeError: Error validating attribute
    
    Caused by:
        string is too long

For more help, visit our troubleshooting guide.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #91313      +/-   ##
==========================================
+ Coverage   87.64%   87.69%   +0.05%     
==========================================
  Files       10348    10340       -8     
  Lines      586372   586674     +302     
  Branches    22559    22613      +54     
==========================================
+ Hits       513939   514499     +560     
+ Misses      71987    71747     -240     
+ Partials      446      428      -18

@aliu39 aliu39 mentioned this pull request May 8, 2025
Merged
michellewzhang
michellewzhang reviewed May 9, 2025
View reviewed changes
@aliu39 aliu39 requested a review from cmanallen May 9, 2025 23:17
cmanallen
cmanallen requested changes May 14, 2025
View reviewed changes
Copy link
Member

@cmanallen cmanallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliu39 Add the archived state to the post_process.py file.

@cmanallen cmanallen merged commit 885fd78 into master May 16, 2025
59 of 60 checks passed
@cmanallen cmanallen deleted the aliu/user-geo-search-config branch May 16, 2025 18:21
cmanallen pushed a commit that referenced this pull request May 16, 2025
@aliu39
feat(replay): add user.geo fields to typeahead (#91315)
efa0ccc 
Depends on #91313
Closes getsentry/team-replay#566
Closes #67001
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
@aliu39 @cmanallen @andrewshie-sentry
feat(replay): make user.geo fields searchable (#91313)
f889713 
Depends on
- getsentry/snuba#7173
- getsentry/snuba#7174
- getsentry/snuba#7175

Ref
- getsentry/team-replay#566

---------

Co-authored-by: Colton Allen <colton.allen@sentry.io>
andrewshie-sentry pushed a commit that referenced this pull request May 20, 2025
@aliu39 @andrewshie-sentry
feat(replay): add user.geo fields to typeahead (#91315)
f96e09e 
Depends on #91313
Closes getsentry/team-replay#566
Closes #67001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michellewzhang michellewzhang michellewzhang left review comments

@cmanallen cmanallen cmanallen approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aliu39 @cmanallen @michellewzhang