fix(taskworker) Remove pickle usage from sentryapps task #91372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `event` parameter of process_service_hook requires pickle. By generating the payload before spawning a task, we don't have to use pickle. Refs SENTRY-3V47
github-actions
bot
added
the
Scope: Backend
markstory
commented
May 9, 2025
Comment on lines
+1197
to
+1202
| process_service_hook.delay( | ||
| servicehook_id=servicehook_id, | ||
| project_id=event.project_id, | ||
| event=event, | ||
| payload=payload, | ||
| ) |
There was a problem hiding this comment.
Because process_service_hook already supports kwargs we can provide the new args at the same time as expanding the signature.
Comment on lines
+57
to
+61
| if not payload: | ||
| if servicehook.version == 0: | ||
| payload = json.dumps(get_payload_v0(event)) | ||
| else: | ||
| raise NotImplementedError |
There was a problem hiding this comment.
Passing in the serialized payload as a string saves us pickle + two json.dumps calls here 🚀
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #91372 +/- ##
==========================================
- Coverage 87.64% 87.63% -0.01%
==========================================
Files 10328 10330 +2
Lines 586134 586295 +161
Branches 22628 22628
==========================================
+ Hits 513713 513826 +113
- Misses 71994 72042 +48
Partials 427 427 |
Christinarlong
approved these changes
May 9, 2025
There was a problem hiding this comment.
Makes sense to me, we're replacing the event parameter/var with the serialized payload.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
|
PR reverted: dfe6a25 |
getsentry-bot
added a commit
that referenced
this pull request
May 10, 2025
)" This reverts commit 81d0180. Co-authored-by: markstory <24086+markstory@users.noreply.github.com>
markstory
added a commit
that referenced
this pull request
May 12, 2025
Redo of #91372 which was reverted because of rate limiting. This time around, use an option to control task variants, and only generate a payload when a hook is going to be sent. For projects with multiple service hooks, this should result in fewer snuba calls as events are only serialized once.
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
The `event` parameter of process_service_hook requires pickle. By generating the payload before spawning a task, we don't have to use pickle. Refs SENTRY-3V47
andrewshie-sentry
pushed a commit
that referenced
this pull request
May 12, 2025
)" This reverts commit 81d0180. Co-authored-by: markstory <24086+markstory@users.noreply.github.com>
markstory
added a commit
that referenced
this pull request
May 12, 2025
Redo of #91372 which was reverted because of rate limiting. This time around, use an option to control task variants, and only generate a payload when a hook is going to be sent. For projects with multiple service hooks, this should result in fewer snuba calls as events are only serialized once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eventparameter of process_service_hook requires pickle. By generating the payload before spawning a task, we don't have to use pickle.Refs SENTRY-3V47